Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复边被重复删除导致edge is not exist报错的问题 #283

Closed
wants to merge 1 commit into from
Closed

fix: 修复边被重复删除导致edge is not exist报错的问题 #283

wants to merge 1 commit into from

Conversation

arthur657834
Copy link
Contributor

修复边被重复删除导致edge is not exist报错的问题
issue: #255
原因: 节点删除会同步删除其关联的边, 导致再接下来的边删除操作中重复删除，控制台输出edge is not exist报错

Description

  1. GraphRenderCommand 中在边删除操作中新增判断
  2. DelNodeCommand修改注释 创建节点命令 为 删除节点命令

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2022

⚠️ No Changeset found

Latest commit: 790698c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xflow-bot xflow-bot bot added fix PR: unreviewed PR does not have any reviews. pkg:xflow-core Denotes a PR that changes packages/xflow-core size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2022
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Jul 26, 2022

Hiya!

This PR has gone quiet. Spooky quiet. 👻

We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!

Thanks for being a part of the AntV community! 💪💯

@xflow-bot xflow-bot bot added the stale Issue that may be closed soon due to the original author not responding any more. label Jul 26, 2022
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Sep 4, 2022

Hey again!

It’s been 60 days since anything happened on this PR, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot 🤖, so if I’ve closed this PR in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this PR or create a new one if you need anything else.

Thanks again for being part of the AntV community! 💪💯

@xflow-bot xflow-bot bot closed this Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix pkg:xflow-core Denotes a PR that changes packages/xflow-core PR: unreviewed PR does not have any reviews. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stale Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arthur657834